[asterisk-dev] [Code Review] 3266: media_formats: Move codecs over.

[Kevin Harwell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3266/#review10986
-----------------------------------------------------------



/team/file/media_formats-impl/codecs/codec_speex.c
<https://reviewboard.asterisk.org/r/3266/#comment20627>

    Not sure if it is optional, but these (speex translantors) are missing the ".format" string.  



/team/file/media_formats-impl/codecs/codec_ulaw.c
<https://reviewboard.asterisk.org/r/3266/#comment20626>

    Same as previously mentioned.  Missing ".format" on the ulaw translators.


- Kevin Harwell


On Feb. 25, 2014, 6:58 a.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3266/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2014, 6:58 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This moves the codec modules over to the new media formats API.
> 
> * Diffs that failed to apply have been done in the apps review.
> 
> 
> Diffs
> -----
> 
>   /team/file/media_formats-impl/main/translate.c 407953 
>   /team/file/media_formats-impl/include/asterisk/translate.h 407954 
>   /team/file/media_formats-impl/include/asterisk/format_cache.h 407954 
>   /team/file/media_formats-impl/codecs/ex_ulaw.h 407953 
>   /team/file/media_formats-impl/codecs/ex_speex.h 407953 
>   /team/file/media_formats-impl/codecs/ex_lpc10.h 407953 
>   /team/file/media_formats-impl/codecs/ex_ilbc.h 407953 
>   /team/file/media_formats-impl/codecs/ex_gsm.h 407953 
>   /team/file/media_formats-impl/codecs/ex_g726.h 407953 
>   /team/file/media_formats-impl/codecs/ex_g722.h 407953 
>   /team/file/media_formats-impl/codecs/ex_alaw.h 407954 
>   /team/file/media_formats-impl/codecs/ex_adpcm.h 407954 
>   /team/file/media_formats-impl/codecs/codec_ulaw.c 407953 
>   /team/file/media_formats-impl/codecs/codec_speex.c 407953 
>   /team/file/media_formats-impl/codecs/codec_resample.c 407953 
>   /team/file/media_formats-impl/codecs/codec_lpc10.c 407953 
>   /team/file/media_formats-impl/codecs/codec_ilbc.c 407953 
>   /team/file/media_formats-impl/codecs/codec_gsm.c 407953 
>   /team/file/media_formats-impl/codecs/codec_g726.c 407953 
>   /team/file/media_formats-impl/codecs/codec_g722.c 407953 
>   /team/file/media_formats-impl/codecs/codec_dahdi.c 407953 
>   /team/file/media_formats-impl/codecs/codec_alaw.c 407953 
>   /team/file/media_formats-impl/codecs/codec_adpcm.c 407954 
>   /team/file/media_formats-impl/codecs/codec_a_mu.c 407953 
> 
> Diff: https://reviewboard.asterisk.org/r/3266/diff/
> 
> 
> Testing
> -------
> 
> They compile, yay!
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140227/8f4a495b/attachment-0001.html>