[asterisk-dev] [Code Review] 3249: Testsuite: manager live_dangerously tests are missing a parameter for on_failure

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3249/#review10970
-----------------------------------------------------------

Ship it!


Ship It!

- opticron


On Feb. 22, 2014, 8:18 p.m., Corey Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3249/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2014, 8:18 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23349
>     https://issues.asterisk.org/jira/browse/ASTERISK-23349
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> AMILoginTest.on_failure should accept 2 parameters (self, reason).  Both manager/danger tests declare the procedure with only a single parameter.  This causes a python backtrace when an AMI error tries calling on_failure.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/manager/danger/safe/run-test 4730 
>   /asterisk/trunk/tests/manager/danger/dangerous/run-test 4730 
> 
> Diff: https://reviewboard.asterisk.org/r/3249/diff/
> 
> 
> Testing
> -------
> 
> Original failure found with old version of starpy that mishandled channel None for AMI getVar.  This change caused the correct error "Failed to execute GetVar" instead of a python backtrace.
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140227/8b63fd1f/attachment-0001.html>