[asterisk-dev] [Code Review] 3249: Testsuite: manager live_dangerously tests are missing a parameter for on_failure

Corey Farrell reviewboard at asterisk.org
Sat Feb 22 20:18:28 CST 2014

This is an automatically generated e-mail. To reply, visit:

Review request for Asterisk Developers.

Bugs: ASTERISK-23349

Repository: testsuite


AMILoginTest.on_failure should accept 2 parameters (self, reason).  Both manager/danger tests declare the procedure with only a single parameter.  This causes a python backtrace when an AMI error tries calling on_failure.


  /asterisk/trunk/tests/manager/danger/safe/run-test 4730 
  /asterisk/trunk/tests/manager/danger/dangerous/run-test 4730 

Diff: https://reviewboard.asterisk.org/r/3249/diff/


Original failure found with old version of starpy that mishandled channel None for AMI getVar.  This change caused the correct error "Failed to execute GetVar" instead of a python backtrace.


Corey Farrell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140223/242ef85f/attachment-0001.html>

More information about the asterisk-dev mailing list