[asterisk-dev] [Code Review] 4286: rtp_engine: avoid payload types above 127

[Scott Griepentrog]

> On Dec. 23, 2014, 7:41 a.m., Joshua Colp wrote:
> > /trunk/main/rtp_engine.c, line 2193
> > <https://reviewboard.asterisk.org/r/4286/diff/1/?file=69966#file69966line2193>
> >
> >     Yeah, put this in the 96-127 rang instead.
> 
> Scott Griepentrog wrote:
>     Wouldn't that cause ast_rtp_engine_load_format() to fail because no dynamic rtp mapping is available?
> 
> Joshua Colp wrote:
>     I don't understand the question?
>     
>     There are unused payloads in the 96-127 range, I'd stick to that range for the reason oej provided as well as because I would not be surprised for implementations to consider that THE dynamic range and potentially have trouble outside of it.

I was incorrect.  There are other available payload numbers in the range.


- Scott


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4286/#review14028
-----------------------------------------------------------


On Dec. 31, 2014, 12:06 p.m., Scott Griepentrog wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4286/
> -----------------------------------------------------------
> 
> (Updated Dec. 31, 2014, 12:06 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24367
>     https://issues.asterisk.org/jira/browse/ASTERISK-24367
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Valid payload type codes are between 0 and 127 to allow for being stored in 7 bits.  During call setup, pjsip validates the SDP and will assert if it encounters an invalid payload type code (see pjmedia_sdp_validate() in pjmedia/src/pjmedia/sdp.c).  This assert will be hit if a call is placed to a pjsip endpoint with allow=all set.
> 
> To avoid this, the previous use 128 for the slin192 format has been changed to 95.
> 
> 
> Diffs
> -----
> 
>   /trunk/main/rtp_engine.c 429845 
> 
> Diff: https://reviewboard.asterisk.org/r/4286/diff/
> 
> 
> Testing
> -------
> 
> Tested with pjsip calls to allow=all configured extensions.
> 
> 
> Thanks,
> 
> Scott Griepentrog
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141231/1f25d2db/attachment-0001.html>