[asterisk-dev] [Code Review] 4286: rtp_engine: avoid payload types above 127

[Scott Griepentrog]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4286/
-----------------------------------------------------------

(Updated Dec. 31, 2014, 12:06 p.m.)


Review request for Asterisk Developers.


Changes
-------

Addressed Josh's findings.


Bugs: ASTERISK-24367
    https://issues.asterisk.org/jira/browse/ASTERISK-24367


Repository: Asterisk


Description
-------

Valid payload type codes are between 0 and 127 to allow for being stored in 7 bits.  During call setup, pjsip validates the SDP and will assert if it encounters an invalid payload type code (see pjmedia_sdp_validate() in pjmedia/src/pjmedia/sdp.c).  This assert will be hit if a call is placed to a pjsip endpoint with allow=all set.

To avoid this, the previous use 128 for the slin192 format has been changed to 95.


Diffs (updated)
-----

  /trunk/main/rtp_engine.c 429845 

Diff: https://reviewboard.asterisk.org/r/4286/diff/


Testing
-------

Tested with pjsip calls to allow=all configured extensions.


Thanks,

Scott Griepentrog

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141231/f7417542/attachment.html>