[asterisk-dev] [Code Review] 4256: testsuite: check for channel leak on failed blonde transfer

[Scott Griepentrog]

> On Dec. 23, 2014, 9:41 a.m., Matt Jordan wrote:
> > /asterisk/trunk/tests/bridge/atxfer_fail_blonde/test-config.yaml, line 35
> > <https://reviewboard.asterisk.org/r/4256/diff/1/?file=69642#file69642line35>
> >
> >     Minimum version should be the minimum expected Asterisk version that contains the fix.
> >     
> >     (1) Are we sure this should run against 11?
> >     (2) What minimum version of 13 should this include?

I would have thought that the minimum version would be the version that had the features being tested, rather than turn off bug detection on earlier revisions just because it hadn't been fixed yet.

Under those conditions, this is correct as all versions 11 forward have this feature - and I've tested it on 11 and it passes where 12 prior to my patches doesn't.


- Scott


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4256/#review14036
-----------------------------------------------------------


On Dec. 31, 2014, 12:01 p.m., Scott Griepentrog wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4256/
> -----------------------------------------------------------
> 
> (Updated Dec. 31, 2014, 12:01 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24513
>     https://issues.asterisk.org/jira/browse/ASTERISK-24513
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This test starts an attended transfer, converts to blonde mode by hanging up the transferer, and then fails the transfer by hanging up the transferee.  Then after allowing the recall attempt to complete, checks to insure that there are not leaked channels.
> 
> Improvements to channel_test_condition: count the actual channels listed in "core show channels" output to check for leaks.  Also added unittest.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/bridge/tests.yaml 6149 
>   /asterisk/trunk/tests/bridge/atxfer_fail_blonde/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/bridge/atxfer_fail_blonde/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/lib/python/asterisk/channel_test_condition.py 6149 
> 
> Diff: https://reviewboard.asterisk.org/r/4256/diff/
> 
> 
> Testing
> -------
> 
> Currently fails while ASTERISK-24513 is not yet patched.
> 
> 
> Thanks,
> 
> Scott Griepentrog
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141231/931116e4/attachment.html>