[asterisk-dev] [Code Review] 4256: testsuite: check for channel leak on failed blonde transfer

Scott Griepentrog reviewboard at asterisk.org
Wed Dec 31 12:01:29 CST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4256/
-----------------------------------------------------------

(Updated Dec. 31, 2014, 12:01 p.m.)


Review request for Asterisk Developers.


Changes
-------

Addressed Matt's findings.


Bugs: ASTERISK-24513
    https://issues.asterisk.org/jira/browse/ASTERISK-24513


Repository: testsuite


Description (updated)
-------

This test starts an attended transfer, converts to blonde mode by hanging up the transferer, and then fails the transfer by hanging up the transferee.  Then after allowing the recall attempt to complete, checks to insure that there are not leaked channels.

Improvements to channel_test_condition: count the actual channels listed in "core show channels" output to check for leaks.  Also added unittest.


Diffs (updated)
-----

  /asterisk/trunk/tests/bridge/tests.yaml 6149 
  /asterisk/trunk/tests/bridge/atxfer_fail_blonde/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/bridge/atxfer_fail_blonde/configs/ast1/extensions.conf PRE-CREATION 
  /asterisk/trunk/lib/python/asterisk/channel_test_condition.py 6149 

Diff: https://reviewboard.asterisk.org/r/4256/diff/


Testing
-------

Currently fails while ASTERISK-24513 is not yet patched.


Thanks,

Scott Griepentrog

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141231/cd1bc6b5/attachment.html>


More information about the asterisk-dev mailing list