[asterisk-dev] [Code Review] 4281: Testsuite: Single channel redirect tests

[Kevin Harwell]

> On Dec. 17, 2014, 5:55 p.m., Mark Michelson wrote:
> > The diff appears to be uploaded relative to the location of the redirect/ directory. This means that there is a tests.yaml file in the parent of redirect/ that is not in this review.

Correct.  I modified the tests.yaml as well, but reviewboard for some reason complains about not being able to find that file in the repository, so I left it out of the review (should have mentioned that) since it is a minor change.


> On Dec. 17, 2014, 5:55 p.m., Mark Michelson wrote:
> > ./redirect/single/bridge/test-config.yaml, lines 50-57
> > <https://reviewboard.asterisk.org/r/4281/diff/1/?file=69833#file69833line50>
> >
> >     Why do you wait for this event? Shouldn't both parties having BridgeEnter events be enough?

The event action module executes all actions for each event received and I needed to have it one event to one action.  This also made sure the call was fully established before attempting to redirect.


> On Dec. 17, 2014, 5:55 p.m., Mark Michelson wrote:
> > ./redirect/single/bridge/test-config.yaml, line 41
> > <https://reviewboard.asterisk.org/r/4281/diff/1/?file=69833#file69833line41>
> >
> >     Hm, I'd expect Local/alice-00000000;2 to be bridged, not Local/alice-00000000;1.

;1 is the one that enters the bridge.  Changing it fails the test.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4281/#review14005
-----------------------------------------------------------


On Dec. 17, 2014, 3:33 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4281/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2014, 3:33 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24536
>     https://issues.asterisk.org/jira/browse/ASTERISK-24536
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> Wrote two tests:
> 
> 1) Redirect a single channel that is in the Echo application, verify that it gets redirected to the appropriate dialplan location, and make sure no surrogate channels are hanging around.
> 
> 2) Redirect a single channel that is in a bridge with another channel, verify that the channel gets redirected to the appropriate dialplan location, and make sure the channel it was bridged with is hung up.
> 
> 
> Diffs
> -----
> 
>   ./redirect/tests.yaml PRE-CREATION 
>   ./redirect/single/tests.yaml PRE-CREATION 
>   ./redirect/single/bridge/test-config.yaml PRE-CREATION 
>   ./redirect/single/bridge/configs/ast1/extensions.conf PRE-CREATION 
>   ./redirect/single/app/test-config.yaml PRE-CREATION 
>   ./redirect/single/app/configs/ast1/extensions.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/4281/diff/
> 
> 
> Testing
> -------
> 
> Ran tests and they passed.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141218/d0b569a4/attachment-0001.html>