[asterisk-dev] [Code Review] 4281: Testsuite: Single channel redirect tests

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4281/#review14005
-----------------------------------------------------------


The diff appears to be uploaded relative to the location of the redirect/ directory. This means that there is a tests.yaml file in the parent of redirect/ that is not in this review.


./redirect/single/bridge/test-config.yaml
<https://reviewboard.asterisk.org/r/4281/#comment24516>

    Hm, I'd expect Local/alice-00000000;2 to be bridged, not Local/alice-00000000;1.



./redirect/single/bridge/test-config.yaml
<https://reviewboard.asterisk.org/r/4281/#comment24517>

    Why do you wait for this event? Shouldn't both parties having BridgeEnter events be enough?



./redirect/single/bridge/test-config.yaml
<https://reviewboard.asterisk.org/r/4281/#comment24518>

    The comments mention the wrong parties.


- Mark Michelson


On Dec. 17, 2014, 9:33 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4281/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2014, 9:33 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24536
>     https://issues.asterisk.org/jira/browse/ASTERISK-24536
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> Wrote two tests:
> 
> 1) Redirect a single channel that is in the Echo application, verify that it gets redirected to the appropriate dialplan location, and make sure no surrogate channels are hanging around.
> 
> 2) Redirect a single channel that is in a bridge with another channel, verify that the channel gets redirected to the appropriate dialplan location, and make sure the channel it was bridged with is hung up.
> 
> 
> Diffs
> -----
> 
>   ./redirect/tests.yaml PRE-CREATION 
>   ./redirect/single/tests.yaml PRE-CREATION 
>   ./redirect/single/bridge/test-config.yaml PRE-CREATION 
>   ./redirect/single/bridge/configs/ast1/extensions.conf PRE-CREATION 
>   ./redirect/single/app/test-config.yaml PRE-CREATION 
>   ./redirect/single/app/configs/ast1/extensions.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/4281/diff/
> 
> 
> Testing
> -------
> 
> Ran tests and they passed.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141217/f5b7585e/attachment-0001.html>