[asterisk-dev] [Code Review] 4101: Channel Originate/Continue via ARI support for labels in dialplan is incomplete

[greenfieldtech]

> On Dec. 17, 2014, 5:14 p.m., Mark Michelson wrote:
> > /trunk/rest-api/api-docs/channels.json, line 374
> > <https://reviewboard.asterisk.org/r/4101/diff/10/?file=69813#file69813line374>
> >
> >     Why is this change present?

I changed this from int to long, for consistency sake. The other functions, referring to priority are all indicated as 'long'.


> On Dec. 17, 2014, 5:14 p.m., Mark Michelson wrote:
> > /trunk/res/ari/resource_channels.c, lines 920-931
> > <https://reviewboard.asterisk.org/r/4101/diff/10/?file=69811#file69811line920>
> >
> >     I have the same comments about these log messages that I did for the previous function.

I'll modify the error messages and re-submit. I was having an issue deciding what message level these should be, so I left them as is right now, in the
hopes one of you guys will point me to the preferred log level.


- greenfieldtech


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4101/#review13983
-----------------------------------------------------------


On Dec. 17, 2014, 12:39 p.m., greenfieldtech wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4101/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2014, 12:39 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24412
>     https://issues.asterisk.org/jira/browse/ASTERISK-24412
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch changes the current behavior of ARI, to allow channel originate/continue requests to be performed with labels as the priority, not only integer values.
> 
> 
> Diffs
> -----
> 
>   /trunk/rest-api/api-docs/channels.json 429698 
>   /trunk/res/res_ari_channels.c 429698 
>   /trunk/res/ari/resource_channels.c 429698 
>   /trunk/res/ari/resource_channels.h 429698 
> 
> Diff: https://reviewboard.asterisk.org/r/4101/diff/
> 
> 
> Testing
> -------
> 
> Testing was performed by testing the following scenarios:
> 1. Originating a call to a numeric priority - works
> 2. Originating a call to a null priority - works
> 3. Originating a call to a label - works
> 4. Continue a call to a label - not tested yet
> 
> 
> Thanks,
> 
> greenfieldtech
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141217/1d272e60/attachment.html>