[asterisk-dev] [Code Review] 4101: Channel Originate/Continue via ARI support for labels in dialplan is incomplete

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4101/#review13983
-----------------------------------------------------------


Thanks for the upload Nir. The remaining issues on the patch are pretty minor, so I think if these can be addressed, this can go in very soon.


/trunk/res/ari/resource_channels.c
<https://reviewboard.asterisk.org/r/4101/#comment24500>

    I think this should be a LOG_WARNING or LOG_ERROR message since it results in a failed operation.



/trunk/res/ari/resource_channels.c
<https://reviewboard.asterisk.org/r/4101/#comment24501>

    I think this should be a debug message, and a high-level one at that, possibly level 2 or 3.
    
    ast_debug(3, "Numeric value provided for label, jumpting to that priority");



/trunk/res/ari/resource_channels.c
<https://reviewboard.asterisk.org/r/4101/#comment24502>

    This is another message that I think should be a warning or error.



/trunk/res/ari/resource_channels.c
<https://reviewboard.asterisk.org/r/4101/#comment24503>

    I have the same comments about these log messages that I did for the previous function.



/trunk/rest-api/api-docs/channels.json
<https://reviewboard.asterisk.org/r/4101/#comment24504>

    Why is this change present?


- Mark Michelson


On Dec. 17, 2014, 12:39 p.m., greenfieldtech wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4101/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2014, 12:39 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24412
>     https://issues.asterisk.org/jira/browse/ASTERISK-24412
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch changes the current behavior of ARI, to allow channel originate/continue requests to be performed with labels as the priority, not only integer values.
> 
> 
> Diffs
> -----
> 
>   /trunk/rest-api/api-docs/channels.json 429698 
>   /trunk/res/res_ari_channels.c 429698 
>   /trunk/res/ari/resource_channels.c 429698 
>   /trunk/res/ari/resource_channels.h 429698 
> 
> Diff: https://reviewboard.asterisk.org/r/4101/diff/
> 
> 
> Testing
> -------
> 
> Testing was performed by testing the following scenarios:
> 1. Originating a call to a numeric priority - works
> 2. Originating a call to a null priority - works
> 3. Originating a call to a label - works
> 4. Continue a call to a label - not tested yet
> 
> 
> Thanks,
> 
> greenfieldtech
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141217/7b4f3097/attachment-0001.html>