[asterisk-dev] [Code Review] 4253: Testsuite: Add tests for use of 'inactive' stream direction for hold

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4253/#review13950
-----------------------------------------------------------

Ship it!


Honestly, writing a run-test file for this is overkill since the entire thing could be taken care of in test-config.yaml using the SIPpTestCase and AMIEventModule. I won't block up this review, though, since I know it was mostly copied from a separate review.

- Mark Michelson


On Dec. 11, 2014, 8:15 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4253/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2014, 8:15 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This adds tests checking the use of the 'inactive' stream direction for setting hold. This is used by some Seimens phones. This is primarily a copy of the existing hold tests for 'sendonly' streams with a little cleanup.
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/tests/channels/pjsip/tests.yaml 6082 
>   asterisk/trunk/tests/channels/pjsip/hold_inactive/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/channels/pjsip/hold_inactive/sipp/phone_B_unhold_sans_sdp.xml PRE-CREATION 
>   asterisk/trunk/tests/channels/pjsip/hold_inactive/sipp/phone_B_media_restrict.xml PRE-CREATION 
>   asterisk/trunk/tests/channels/pjsip/hold_inactive/sipp/phone_B_hold_update.xml PRE-CREATION 
>   asterisk/trunk/tests/channels/pjsip/hold_inactive/sipp/phone_B_duplicate_hold.xml PRE-CREATION 
>   asterisk/trunk/tests/channels/pjsip/hold_inactive/sipp/phone_B_IP_media_restrict.xml PRE-CREATION 
>   asterisk/trunk/tests/channels/pjsip/hold_inactive/sipp/phone_A.xml PRE-CREATION 
>   asterisk/trunk/tests/channels/pjsip/hold_inactive/sipp/inject.csv PRE-CREATION 
>   asterisk/trunk/tests/channels/pjsip/hold_inactive/run-test PRE-CREATION 
>   asterisk/trunk/tests/channels/pjsip/hold_inactive/configs/ast1/pjsip.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/pjsip/hold_inactive/configs/ast1/extensions.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/4253/diff/
> 
> 
> Testing
> -------
> 
> Ensured that the tests functioned as expected.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141211/ff4da723/attachment.html>