<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/4253/">https://reviewboard.asterisk.org/r/4253/</a>
     </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Honestly, writing a run-test file for this is overkill since the entire thing could be taken care of in test-config.yaml using the SIPpTestCase and AMIEventModule. I won't block up this review, though, since I know it was mostly copied from a separate review.</pre>
 <br />









<p>- Mark Michelson</p>


<br />
<p>On December 11th, 2014, 8:15 p.m. UTC, opticron wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By opticron.</div>


<p style="color: grey;"><i>Updated Dec. 11, 2014, 8:15 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This adds tests checking the use of the 'inactive' stream direction for setting hold. This is used by some Seimens phones. This is primarily a copy of the existing hold tests for 'sendonly' streams with a little cleanup.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ensured that the tests functioned as expected.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>asterisk/trunk/tests/channels/pjsip/tests.yaml <span style="color: grey">(6082)</span></li>

 <li>asterisk/trunk/tests/channels/pjsip/hold_inactive/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>asterisk/trunk/tests/channels/pjsip/hold_inactive/sipp/phone_B_unhold_sans_sdp.xml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>asterisk/trunk/tests/channels/pjsip/hold_inactive/sipp/phone_B_media_restrict.xml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>asterisk/trunk/tests/channels/pjsip/hold_inactive/sipp/phone_B_hold_update.xml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>asterisk/trunk/tests/channels/pjsip/hold_inactive/sipp/phone_B_duplicate_hold.xml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>asterisk/trunk/tests/channels/pjsip/hold_inactive/sipp/phone_B_IP_media_restrict.xml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>asterisk/trunk/tests/channels/pjsip/hold_inactive/sipp/phone_A.xml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>asterisk/trunk/tests/channels/pjsip/hold_inactive/sipp/inject.csv <span style="color: grey">(PRE-CREATION)</span></li>

 <li>asterisk/trunk/tests/channels/pjsip/hold_inactive/run-test <span style="color: grey">(PRE-CREATION)</span></li>

 <li>asterisk/trunk/tests/channels/pjsip/hold_inactive/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>

 <li>asterisk/trunk/tests/channels/pjsip/hold_inactive/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/4253/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>