[asterisk-dev] [Code Review] 4246: PJSIP: Stagger outbound qualifies

[opticron]

> On Dec. 8, 2014, 1:47 p.m., rmudgett wrote:
> > branches/12/res/res_pjsip/pjsip_options.c, lines 416-421
> > <https://reviewboard.asterisk.org/r/4246/diff/2/?file=69600#file69600line416>
> >
> >     You need to check that the returned value is never zero.  qualify_frequency could become zero if the user disables qualify on a config reload.

The config reload can't affect the contact object stored in the data blob held by the scheduler since the contact object is an immutable sorcery object. The scheduler callback would have to request a new snapshot to get the new config value. A config change that disables qualification on the given contact would remove the scheduler entry and then not start a new one since qualify_frequency would be 0 (see qualify_and_schedule()).


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4246/#review13924
-----------------------------------------------------------


On Dec. 8, 2014, 1:16 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4246/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2014, 1:16 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24342
>     https://issues.asterisk.org/jira/browse/ASTERISK-24342
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This change staggers initiation of outbound qualify (OPTIONS) attempts to reduce instantaneous server load and prevent network congestion.
> 
> 
> Diffs
> -----
> 
>   branches/12/res/res_pjsip/pjsip_options.c 429060 
>   branches/12/CHANGES 429060 
> 
> Diff: https://reviewboard.asterisk.org/r/4246/diff/
> 
> 
> Testing
> -------
> 
> Verified that this did not break the existing qualify test and used wireshark to verify that the OPTIONS messages were being sent at staggered intervals with the patch and all at once without the patch.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141208/b2393a46/attachment.html>