[asterisk-dev] [Code Review] 4246: PJSIP: Stagger outbound qualifies

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4246/#review13924
-----------------------------------------------------------



branches/12/res/res_pjsip/pjsip_options.c
<https://reviewboard.asterisk.org/r/4246/#comment24447>

    You need to check that the returned value is never zero.  qualify_frequency could become zero if the user disables qualify on a config reload.


- rmudgett


On Dec. 8, 2014, 1:16 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4246/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2014, 1:16 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24342
>     https://issues.asterisk.org/jira/browse/ASTERISK-24342
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This change staggers initiation of outbound qualify (OPTIONS) attempts to reduce instantaneous server load and prevent network congestion.
> 
> 
> Diffs
> -----
> 
>   branches/12/res/res_pjsip/pjsip_options.c 429060 
>   branches/12/CHANGES 429060 
> 
> Diff: https://reviewboard.asterisk.org/r/4246/diff/
> 
> 
> Testing
> -------
> 
> Verified that this did not break the existing qualify test and used wireshark to verify that the OPTIONS messages were being sent at staggered intervals with the patch and all at once without the patch.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141208/6b6bdd4a/attachment.html>