[asterisk-dev] [Code Review] 4245: ARI/AMI: Include language in standard channel snapshot output

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4245/#review13912
-----------------------------------------------------------

Ship it!


Ship It!

- Joshua Colp


On Dec. 5, 2014, 11:12 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4245/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2014, 11:12 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24553
>     https://issues.asterisk.org/jira/browse/ASTERISK-24553
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The channel "language" was already part of a channel snapshot, however is was not sent out over AMI or ARI. This patch makes it so the channel "language" is included in the appropriate AMI or ARI events.
> 
> Also updated the ARI user channel events testsuite test to check for the field (updated test to check both ARI and AMI). Since it was such a small change I've just added it as a file attachment to this review.
> 
> 
> Diffs
> -----
> 
>   branches/12/rest-api/api-docs/channels.json 428998 
>   branches/12/res/ari/ari_model_validators.c 428998 
>   branches/12/res/ari/ari_model_validators.h 428998 
>   branches/12/main/stasis_channels.c 428998 
>   branches/12/main/manager_channels.c 428998 
> 
> Diff: https://reviewboard.asterisk.org/r/4245/diff/
> 
> 
> Testing
> -------
> 
> Manually tested both AMI and ARI to make sure the channel "language" was now being included in raised events. Also ran the updated testsuite test and made sure it passed.
> 
> 
> File Attachments
> ----------------
> 
> Updated ARI/AMI event test changes.
>   https://reviewboard.asterisk.org/media/uploaded/files/2014/12/05/95b84a56-1671-4ecc-8694-ac3952d3d49c__language_test.diff
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141208/9b2cb5e5/attachment.html>