[asterisk-dev] [Code Review] 4226: Testsuite: Add tests for external interactions with ARI/Stasis

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4226/
-----------------------------------------------------------

(Updated Dec. 4, 2014, 11:52 a.m.)


Review request for Asterisk Developers and Mark Michelson.


Changes
-------

Address Matt's comments.


Bugs: ASTERISK-24537
    https://issues.asterisk.org/jira/browse/ASTERISK-24537


Repository: testsuite


Description
-------

This reorganizes existing tests that affect channels in Stasis() via external mechanisms and adds new tests to cover other interactions not yet represented in the testsuite. An additional, more comprehensive test for attended transfers has been added as well as tests for bridged and unbridged channels in Stasis() being affected by AMI Bridge and Redirect actions. The bug reported in ASTERISK-24591 was found while writing these tests.

This also modifies the ARI python libraries to allow parameters to have substituted variables.

This covers tests 1.3, 2.1.1, 2.10.1, 3.1, and 3.2 from the StasisStart/StasisEnd test plan available here: https://wiki.asterisk.org/wiki/pages/viewpage.action?pageId=30279826

The two existing attended and blind transfer tests cover tests 1.4 and 1.9.


Diffs (updated)
-----

  asterisk/trunk/tests/rest_api/tests.yaml 6018 
  asterisk/trunk/tests/rest_api/external_interaction/tests.yaml PRE-CREATION 
  asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/tests.yaml PRE-CREATION 
  asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_same_stasis_app/test-config.yaml PRE-CREATION 
  asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_same_stasis_app/configs/ast1/pjsip.conf PRE-CREATION 
  asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_same_stasis_app/configs/ast1/extensions.conf PRE-CREATION 
  asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_same_stasis_app/blind_transfer.py PRE-CREATION 
  asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/tests.yaml PRE-CREATION 
  asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_stasis_app/test-config.yaml PRE-CREATION 
  asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_stasis_app/sipp/referer.xml PRE-CREATION 
  asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_stasis_app/sipp/referee.xml PRE-CREATION 
  asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_stasis_app/configs/ast1/pjsip.conf PRE-CREATION 
  asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_stasis_app/configs/ast1/extensions.conf PRE-CREATION 
  asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_non_stasis_app/test-config.yaml PRE-CREATION 
  asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_non_stasis_app/sipp/referer.xml PRE-CREATION 
  asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_non_stasis_app/sipp/referee.xml PRE-CREATION 
  asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_non_stasis_app/configs/ast1/pjsip.conf PRE-CREATION 
  asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_non_stasis_app/configs/ast1/extensions.conf PRE-CREATION 
  asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/attended_transfer.py PRE-CREATION 
  asterisk/trunk/tests/rest_api/external_interaction/ami_redirect/tests.yaml PRE-CREATION 
  asterisk/trunk/tests/rest_api/external_interaction/ami_redirect/stasis_bridge/test-config.yaml PRE-CREATION 
  asterisk/trunk/tests/rest_api/external_interaction/ami_redirect/stasis_bridge/configs/ast1/extensions.conf PRE-CREATION 
  asterisk/trunk/tests/rest_api/external_interaction/ami_redirect/stasis_app/test-config.yaml PRE-CREATION 
  asterisk/trunk/tests/rest_api/external_interaction/ami_redirect/stasis_app/configs/ast1/extensions.conf PRE-CREATION 
  asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/tests.yaml PRE-CREATION 
  asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/test-config.yaml PRE-CREATION 
  asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/configs/ast1/extensions.conf PRE-CREATION 
  asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_app/test-config.yaml PRE-CREATION 
  asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_app/configs/ast1/extensions.conf PRE-CREATION 
  asterisk/trunk/tests/rest_api/bridges/tests.yaml 6018 
  asterisk/trunk/tests/rest_api/bridges/blind_transfer/test-config.yaml 6018 
  asterisk/trunk/tests/rest_api/bridges/blind_transfer/configs/ast1/pjsip.conf 6018 
  asterisk/trunk/tests/rest_api/bridges/blind_transfer/configs/ast1/extensions.conf 6018 
  asterisk/trunk/tests/rest_api/bridges/blind_transfer/blind_transfer.py 6018 
  asterisk/trunk/tests/rest_api/bridges/attended_transfer/test-config.yaml 6018 
  asterisk/trunk/tests/rest_api/bridges/attended_transfer/sipp/referer.xml 6018 
  asterisk/trunk/tests/rest_api/bridges/attended_transfer/sipp/referee.xml 6018 
  asterisk/trunk/tests/rest_api/bridges/attended_transfer/configs/ast1/pjsip.conf 6018 
  asterisk/trunk/tests/rest_api/bridges/attended_transfer/configs/ast1/extensions.conf 6018 
  asterisk/trunk/tests/rest_api/bridges/attended_transfer/attended_transfer.py 6018 
  asterisk/trunk/lib/python/asterisk/ari.py 6018 

Diff: https://reviewboard.asterisk.org/r/4226/diff/


Testing
-------

Ran the tests and verified they passed with the expected events when the fix in 4213 is applied.


Thanks,

opticron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141204/5f5b4744/attachment-0001.html>