<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/4226/">https://reviewboard.asterisk.org/r/4226/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and Mark Michelson.</div>
<div>By opticron.</div>
<p style="color: grey;"><i>Updated Dec. 4, 2014, 11:52 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Address Matt's comments.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-24537">ASTERISK-24537</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This reorganizes existing tests that affect channels in Stasis() via external mechanisms and adds new tests to cover other interactions not yet represented in the testsuite. An additional, more comprehensive test for attended transfers has been added as well as tests for bridged and unbridged channels in Stasis() being affected by AMI Bridge and Redirect actions. The bug reported in ASTERISK-24591 was found while writing these tests.
This also modifies the ARI python libraries to allow parameters to have substituted variables.
This covers tests 1.3, 2.1.1, 2.10.1, 3.1, and 3.2 from the StasisStart/StasisEnd test plan available here: https://wiki.asterisk.org/wiki/pages/viewpage.action?pageId=30279826
The two existing attended and blind transfer tests cover tests 1.4 and 1.9.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ran the tests and verified they passed with the expected events when the fix in 4213 is applied.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>asterisk/trunk/tests/rest_api/tests.yaml <span style="color: grey">(6018)</span></li>
<li>asterisk/trunk/tests/rest_api/external_interaction/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_same_stasis_app/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_same_stasis_app/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_same_stasis_app/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_same_stasis_app/blind_transfer.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_stasis_app/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_stasis_app/sipp/referer.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_stasis_app/sipp/referee.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_stasis_app/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_stasis_app/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_non_stasis_app/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_non_stasis_app/sipp/referer.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_non_stasis_app/sipp/referee.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_non_stasis_app/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_non_stasis_app/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/attended_transfer.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/rest_api/external_interaction/ami_redirect/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/rest_api/external_interaction/ami_redirect/stasis_bridge/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/rest_api/external_interaction/ami_redirect/stasis_bridge/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/rest_api/external_interaction/ami_redirect/stasis_app/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/rest_api/external_interaction/ami_redirect/stasis_app/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_app/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_app/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/rest_api/bridges/tests.yaml <span style="color: grey">(6018)</span></li>
<li>asterisk/trunk/tests/rest_api/bridges/blind_transfer/test-config.yaml <span style="color: grey">(6018)</span></li>
<li>asterisk/trunk/tests/rest_api/bridges/blind_transfer/configs/ast1/pjsip.conf <span style="color: grey">(6018)</span></li>
<li>asterisk/trunk/tests/rest_api/bridges/blind_transfer/configs/ast1/extensions.conf <span style="color: grey">(6018)</span></li>
<li>asterisk/trunk/tests/rest_api/bridges/blind_transfer/blind_transfer.py <span style="color: grey">(6018)</span></li>
<li>asterisk/trunk/tests/rest_api/bridges/attended_transfer/test-config.yaml <span style="color: grey">(6018)</span></li>
<li>asterisk/trunk/tests/rest_api/bridges/attended_transfer/sipp/referer.xml <span style="color: grey">(6018)</span></li>
<li>asterisk/trunk/tests/rest_api/bridges/attended_transfer/sipp/referee.xml <span style="color: grey">(6018)</span></li>
<li>asterisk/trunk/tests/rest_api/bridges/attended_transfer/configs/ast1/pjsip.conf <span style="color: grey">(6018)</span></li>
<li>asterisk/trunk/tests/rest_api/bridges/attended_transfer/configs/ast1/extensions.conf <span style="color: grey">(6018)</span></li>
<li>asterisk/trunk/tests/rest_api/bridges/attended_transfer/attended_transfer.py <span style="color: grey">(6018)</span></li>
<li>asterisk/trunk/lib/python/asterisk/ari.py <span style="color: grey">(6018)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/4226/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>