[asterisk-dev] [Code Review] 4218: res_pjsip_refer: Remove framehook when transfer is marked as completed as a result of joining a bridge

Joshua Colp reviewboard at asterisk.org
Tue Dec 2 06:20:15 CST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4218/
-----------------------------------------------------------

(Updated Dec. 2, 2014, 6:20 a.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
-------

Committed in revision 428760


Repository: Asterisk


Description
-------

There are two methods within res_pjsip_refer for keeping track of the state of a transfer. The first is a framehook which looks at frames passing by to determine the state. The second subscribes to know when the channel joins a bridge. In the case when the channel joins the bridge the framehook is *NOT* removed and this prevents the native RTP bridging technology from getting used.

This change will get the channel and if it still exists remove the framehook.


Diffs
-----

  /branches/12/res/res_pjsip_refer.c 428631 

Diff: https://reviewboard.asterisk.org/r/4218/diff/


Testing
-------

An environment was set up with multiple phones and a blind transfer was performed. Before the patch the bridge after completion of the transfer would be of type simple_bridge. With the patch the bridge after completion would be of type native_rtp.


Thanks,

Joshua Colp

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141202/07772c0e/attachment.html>


More information about the asterisk-dev mailing list