[asterisk-dev] [Code Review] 4218: res_pjsip_refer: Remove framehook when transfer is marked as completed as a result of joining a bridge

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4218/#review13854
-----------------------------------------------------------

Ship it!


Ship It!

- Matt Jordan


On Dec. 1, 2014, 10:24 a.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4218/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2014, 10:24 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> There are two methods within res_pjsip_refer for keeping track of the state of a transfer. The first is a framehook which looks at frames passing by to determine the state. The second subscribes to know when the channel joins a bridge. In the case when the channel joins the bridge the framehook is *NOT* removed and this prevents the native RTP bridging technology from getting used.
> 
> This change will get the channel and if it still exists remove the framehook.
> 
> 
> Diffs
> -----
> 
>   /branches/12/res/res_pjsip_refer.c 428631 
> 
> Diff: https://reviewboard.asterisk.org/r/4218/diff/
> 
> 
> Testing
> -------
> 
> An environment was set up with multiple phones and a blind transfer was performed. Before the patch the bridge after completion of the transfer would be of type simple_bridge. With the patch the bridge after completion would be of type native_rtp.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141201/5de33d7d/attachment.html>