[asterisk-dev] [Code Review] 4211: Speed up loopback switches by avoiding unneeded lookups

Joshua Colp reviewboard at asterisk.org
Mon Dec 1 08:49:23 CST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4211/#review13853
-----------------------------------------------------------

Ship it!


Ship It!

- Joshua Colp


On Nov. 24, 2014, 1:15 a.m., Birger Harzenetter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4211/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2014, 1:15 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Just a small rearrangement to only do dialplan lookups if the pattern matches instead of discarding the result.
> Dialplan lookups can be very costly if remote switches - like dundi - are present.
> In those cases extension matching is sped up considerably, making the issue of lost digits more manageable.
> 
> I've left the extra debug value, I added before hitting the obvious.
> 
> As collateral damage, 6 trailing spaces were killed.
> 
> 
> Diffs
> -----
> 
>   trunk/pbx/pbx_loopback.c 428600 
> 
> Diff: https://reviewboard.asterisk.org/r/4211/diff/
> 
> 
> Testing
> -------
> 
> Works for me (tm)
> 
> 
> Thanks,
> 
> Birger Harzenetter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141201/6ac7e38c/attachment.html>


More information about the asterisk-dev mailing list