[asterisk-dev] [Code Review] 4201: app_record: prevent stripping 1/4 second audio when channel is hung up to end recording.

[Ben Smithurst]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4201/
-----------------------------------------------------------

(Updated Dec. 1, 2014, 7:39 a.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
-------

Committed in revision 428653


Bugs: ASTERISK-24530
    https://issues.asterisk.org/jira/browse/ASTERISK-24530


Repository: Asterisk


Description
-------

We are encountering a problem recording using the Record app with 'k' option, and hanging up to end the recording, as Asterisk is stripping 1/4 second from the end.  This is breaking some of our automated tests which record/playback audio and so on.

It is not clear why this stripping is done but the best guess seems to be related to stripping DTMF tones, as it is NOT done if the recording is ended by timeout, and the code pre-dates the 'k' option.

This patch should maintain existing behaviour for DTMF termination and timeouts, but prevent stripping in the 'hangup' case.


Diffs
-----

  /trunk/apps/app_record.c 428525 

Diff: https://reviewboard.asterisk.org/r/4201/diff/


Testing
-------

Our in-house automated tests which compare audio are much happier with this patch.  No problems observed with DTMF termination of recordings either.

To clarify we have tested this on 11.9.0, I have submitted the patch against trunk, it applies to either.


Thanks,

Ben Smithurst

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141201/a3623a84/attachment.html>