[asterisk-dev] [Code Review] 3867: [chan_sip] Default DTLS settings to use if peer misses own settings

[Michael K.]

> On July 30, 2014, 3:34 p.m., Mark Michelson wrote:
> > trunk/channels/chan_sip.c, lines 30871-30893
> > <https://reviewboard.asterisk.org/r/3867/diff/1/?file=65719#file65719line30871>
> >
> >     If you use ast_rtp_dtls_cfg_copy() above as I recommend, then this entire block can be removed.
> >     
> >     All default values will already be copied onto the peer. Any peer-specific value encountered in the configuration will be copied onto the peer by ast_rtp_dtls_cfg_parse().
> 
> Michael K. wrote:
>     While with TLS if i set encyption to yes and turn on TLS in general, it would load those settings only for those who are using protocol TLS and it would not disturb those who are UDP for example.
>     With DTLS it's little bit different, if i turn it on in general it would be used by default for all peers, including those who has no dtlsenable settings, which breaks all of them and makes dtlsenable=no setting mandatory for all those who do not want/support DTLS. At least for second version of patch. While in first version it actually did not break those and if peer has no dtlsenable setting turned to on it would not load default dtls settings to peer. And only load default if set to "yes" and miss that specific setting.
>     
>     I think my first version with part before loop and part after loop is the better solution as it's more backward compatiable and default settings for DTLS in [general] means the default settings if the dtls is enabled on peer only.

Still waiting for reply till i update the patch


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3867/#review12924
-----------------------------------------------------------


On Aug. 3, 2014, 8:57 a.m., Michael K. wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3867/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2014, 8:57 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24128
>     https://issues.asterisk.org/jira/browse/ASTERISK-24128
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Load default dtls settings from [general settings]
> If peer has dtls enabled but misses some of the settings and they are set in default settings it would load them from there.
> It would be logical as most of sip settings work like that and as well as there is no way to use template in realtime and it would lead to copy paste same settings for every peer.
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_sip.c 419849 
> 
> Diff: https://reviewboard.asterisk.org/r/3867/diff/
> 
> 
> Testing
> -------
> 
> Test on development server (ast 11.11.0)
> 
> 
> Thanks,
> 
> Michael K.
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140828/cc1d4057/attachment-0001.html>