[asterisk-dev] [Code Review] 3867: [chan_sip] Default DTLS settings to use if peer misses own settings

Michael K. reviewboard at asterisk.org
Tue Aug 5 08:35:36 CDT 2014



> On Aug. 5, 2014, 12:37 p.m., Jeremy Lainé wrote:
> > trunk/channels/chan_sip.c, line 31270
> > <https://reviewboard.asterisk.org/r/3867/diff/2/?file=66137#file66137line31270>
> >
> >     This looks like a typo, did you mean default_dtls_cfg?

yeap, gonna apply the fix


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3867/#review12981
-----------------------------------------------------------


On Aug. 3, 2014, 8:57 a.m., Michael K. wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3867/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2014, 8:57 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24128
>     https://issues.asterisk.org/jira/browse/ASTERISK-24128
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Load default dtls settings from [general settings]
> If peer has dtls enabled but misses some of the settings and they are set in default settings it would load them from there.
> It would be logical as most of sip settings work like that and as well as there is no way to use template in realtime and it would lead to copy paste same settings for every peer.
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_sip.c 419849 
> 
> Diff: https://reviewboard.asterisk.org/r/3867/diff/
> 
> 
> Testing
> -------
> 
> Test on development server (ast 11.11.0)
> 
> 
> Thanks,
> 
> Michael K.
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140805/d36db01a/attachment.html>


More information about the asterisk-dev mailing list