[asterisk-dev] [Code Review] 3944: app_confbridge: Add 'all' to channel target for mute and unmute.

George Joseph reviewboard at asterisk.org
Tue Aug 26 12:35:26 CDT 2014

This is an automatically generated e-mail. To reply, visit:

(Updated Aug. 26, 2014, 11:35 a.m.)

Review request for Asterisk Developers.


Addressed Richard's issues.
Refactored the tests for all and participants so they're only done once.

Repository: Asterisk


Although tab completion for confbridge mute and unmute show 'all' as a valid channel target, it was never implemented.

This patch updates mute and unmute (both CLI and AMI) to allow the 'all' target.  They now work as kick does.  Since I was there, I made the channel name case-insensitive since kick was already case-insensitive.

Diffs (updated)

  branches/12/apps/app_confbridge.c 422052 

Diff: https://reviewboard.asterisk.org/r/3944/diff/


Tested that both CLI and AMI handle 'all' and 'participants' as a channel target for mute, unmute and kick correctly.


George Joseph

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140826/c2711fab/attachment.html>

More information about the asterisk-dev mailing list