[asterisk-dev] [Code Review] 3944: app_confbridge: Add 'all' to channel target for mute and unmute.

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3944/#review13178
-----------------------------------------------------------


I think the addition of participants is getting to be overkill.  Your previous version of the patch was better.

However, this patch has pointed out some preexisting bugs in generic_mute_unmute_helper() and complete_confbridge_participant().


branches/12/apps/app_confbridge.c
<https://reviewboard.asterisk.org/r/3944/#comment23642>

    Returning just isn't going to work for all or participants.



branches/12/apps/app_confbridge.c
<https://reviewboard.asterisk.org/r/3944/#comment23643>

    Same here



branches/12/apps/app_confbridge.c
<https://reviewboard.asterisk.org/r/3944/#comment23648>

    Don't decrement state at all.
    
    The state variable is badly named it indicates to get the nth matching string of the partial word given.



branches/12/apps/app_confbridge.c
<https://reviewboard.asterisk.org/r/3944/#comment23647>

    You need to find the conference first before you should return any string.



branches/12/apps/app_confbridge.c
<https://reviewboard.asterisk.org/r/3944/#comment23645>

    strncmp/strncasecmp seems just wrong here.  Should just be strcasecmp.



branches/12/apps/app_confbridge.c
<https://reviewboard.asterisk.org/r/3944/#comment23646>

    and here


- rmudgett


On Aug. 25, 2014, 6:53 p.m., George Joseph wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3944/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2014, 6:53 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Although tab completion for confbridge mute and unmute show 'all' as a valid channel target, it was never implemented.
> 
> This patch updates mute and unmute (both CLI and AMI) to allow the 'all' target.  They now work as kick does.  Since I was there, I made the channel name case-insensitive since kick was already case-insensitive.
> 
> 
> Diffs
> -----
> 
>   branches/12/apps/app_confbridge.c 422052 
> 
> Diff: https://reviewboard.asterisk.org/r/3944/diff/
> 
> 
> Testing
> -------
> 
> Tested that both CLI and AMI handle 'all' and 'participants' as a channel target for mute, unmute and kick correctly.
> 
> 
> Thanks,
> 
> George Joseph
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140826/991391de/attachment-0001.html>