[asterisk-dev] [Code Review] 3933: CallerID: Fix parsing of malformed callerid strings - Asterisk 12+

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3933/
-----------------------------------------------------------

(Updated Aug. 25, 2014, 8:59 p.m.)


Review request for Asterisk Developers.


Changes
-------

Address comments from the other review.


Repository: Asterisk


Description
-------

This allows the callerid parsing function to handle malformed input strings and strings containing escaped and unescaped double quotes. This also adds a unittest to cover many of the cases where the parsing algorithm previously failed.

This corrects a bug in the PJSIP backend that allows quoted callerid strings to contain unescaped quotes which can cause phones to ignore INVITEs entirely.


Diffs (updated)
-----

  branches/12/tests/test_utils.c 421534 
  branches/12/tests/test_callerid.c PRE-CREATION 
  branches/12/res/res_pjsip_caller_id.c 421534 
  branches/12/main/utils.c 421534 
  branches/12/main/callerid.c 421534 
  branches/12/include/asterisk/utils.h 421534 
  branches/12/channels/chan_sip.c 421534 

Diff: https://reviewboard.asterisk.org/r/3933/diff/


Testing
-------

Ran the unittest and ran manual call tests.


Thanks,

opticron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140826/98b36917/attachment.html>