[asterisk-dev] [Code Review] 3933: CallerID: Fix parsing of malformed callerid strings - Asterisk 12+

opticron reviewboard at asterisk.org
Mon Aug 25 15:52:39 CDT 2014

This is an automatically generated e-mail. To reply, visit:

(Updated Aug. 25, 2014, 3:52 p.m.)

Review request for Asterisk Developers.


Update based on comments on 3923.

Repository: Asterisk


This allows the callerid parsing function to handle malformed input strings and strings containing escaped and unescaped double quotes. This also adds a unittest to cover many of the cases where the parsing algorithm previously failed.

This corrects a bug in the PJSIP backend that allows quoted callerid strings to contain unescaped quotes which can cause phones to ignore INVITEs entirely.

Diffs (updated)

  branches/12/tests/test_utils.c 421975 
  branches/12/res/res_pjsip_caller_id.c 421975 
  branches/12/main/utils.c 421975 
  branches/12/main/callerid.c 421975 
  branches/12/include/asterisk/utils.h 421975 
  branches/12/channels/chan_sip.c 421975 

Diff: https://reviewboard.asterisk.org/r/3933/diff/


Ran the unittest and ran manual call tests.



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140825/adfb8bed/attachment.html>

More information about the asterisk-dev mailing list