[asterisk-dev] [Code Review] 3904: Replace some code with ao2_replace().

rmudgett reviewboard at asterisk.org
Thu Aug 14 10:54:54 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3904/
-----------------------------------------------------------

(Updated Aug. 14, 2014, 10:54 a.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
-------

Committed in revision 420992


Repository: Asterisk


Description
-------

Use ao2_replace() instead of ao2_cleanup(); ao2_bump().
ao2_replace() has the advantange of not altering the ref count if the replaced pointer is the same.


Diffs
-----

  /branches/13/main/channel_internal_api.c 420838 
  /branches/13/main/channel.c 420838 

Diff: https://reviewboard.asterisk.org/r/3904/diff/


Testing
-------

Compiler is still happy.


Thanks,

rmudgett

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140814/7c6253dc/attachment.html>


More information about the asterisk-dev mailing list