[asterisk-dev] [Code Review] 3904: Replace some code with ao2_replace().

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3904/#review13084
-----------------------------------------------------------

Ship it!


Ship It!

- opticron


On Aug. 11, 2014, 4:52 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3904/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2014, 4:52 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Use ao2_replace() instead of ao2_cleanup(); ao2_bump().
> ao2_replace() has the advantange of not altering the ref count if the replaced pointer is the same.
> 
> 
> Diffs
> -----
> 
>   /branches/13/main/channel_internal_api.c 420838 
>   /branches/13/main/channel.c 420838 
> 
> Diff: https://reviewboard.asterisk.org/r/3904/diff/
> 
> 
> Testing
> -------
> 
> Compiler is still happy.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140813/06e900ed/attachment.html>