[asterisk-dev] [Code Review] 3901: logger: *strip* the verbose characters instead of blanking them out.

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3901/#review13064
-----------------------------------------------------------

Ship it!


Ship It!

- Matt Jordan


On Aug. 11, 2014, 4:37 a.m., wdoekes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3901/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2014, 4:37 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> There's a function called "logger_strip_verbose_magic". It didn't strip the verbose characters, but replaced them with a space.
> 
> If that's all we wanted, we could've just edited the string inline and wouldn't need the extra malloc. Further, it rescanned the string from the start after every blanking operation.
> 
> This change changes the function to actually strip the verbose magic characters from the log file.
> 
> 
> Diffs
> -----
> 
>   /branches/13/main/logger.c 420653 
> 
> Diff: https://reviewboard.asterisk.org/r/3901/diff/
> 
> 
> Testing
> -------
> 
> Yes. The console output looks the same as the log output.
> 
> 
> Thanks,
> 
> wdoekes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140811/cd542130/attachment-0001.html>