[asterisk-dev] [Code Review] 3901: logger: *strip* the verbose characters instead of blanking them out.

wdoekes reviewboard at asterisk.org
Mon Aug 11 04:37:36 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3901/
-----------------------------------------------------------

Review request for Asterisk Developers.


Repository: Asterisk


Description
-------

There's a function called "logger_strip_verbose_magic". It didn't strip the verbose characters, but replaced them with a space.

If that's all we wanted, we could've just edited the string inline and wouldn't need the extra malloc. Further, it rescanned the string from the start after every blanking operation.

This change changes the function to actually strip the verbose magic characters from the log file.


Diffs
-----

  /branches/13/main/logger.c 420653 

Diff: https://reviewboard.asterisk.org/r/3901/diff/


Testing
-------

Yes. The console output looks the same as the log output.


Thanks,

wdoekes

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140811/af7e13ae/attachment.html>


More information about the asterisk-dev mailing list