[asterisk-dev] [Code Review] 3471: Filesystem based dynamic MoH classes

[Jonathan Rose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3471/#review11720
-----------------------------------------------------------



/trunk/CHANGES
<https://reviewboard.asterisk.org/r/3471/#comment21496>

    Since this patch involves new features and doesn't really have anything to do with ARI or the new PJSIP channel driver, it would almost certainly belong in trunk and not in 12.X
    
    The diff is showing up as being against trunk, so I suspect this is just a misplaced CHANGES note. Just up above is changes from Asterisk 12 to Asterisk 13, so this would go there.



/trunk/res/res_musiconhold.c
<https://reviewboard.asterisk.org/r/3471/#comment21495>

    You've got a number of coding style violations that need to be addressed.
    
    https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines


- Jonathan Rose


On April 22, 2014, 8:57 a.m., Vitezslav Novy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3471/
> -----------------------------------------------------------
> 
> (Updated April 22, 2014, 8:57 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23636
>     https://issues.asterisk.org/jira/browse/ASTERISK-23636
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch introduces another approach to dynamically controlled MoH.
> Unlike realtime this way is file based.
> 
> As a switch between normal and alternative behavior, boolean variable
> 'dynamic' is used in MoH config file.
> 
> By setting
> 
> dynamic=yes
> 
> new behavior is switched on.
> 
> How dynamic behavior works
> 
> All static MoH classes in musiconhold.conf and realtime are ignored, except [default]
> class. On the other hand dynamic class named 'default' is ignored too.
> 
> New variable 'dynamic_dir' defines directory, where dynamic classes are
> defined. Each first level subdirectory of dynamic_dir defines one MoH class
> with same name as directory name.
> If class directory contains playlist file 'playlist.txt' content of
> the file defines audiofiles in class and their order. Otherwise directory
> is scanned same way as for standard MoH class with mode=files.
> 
> Playlist expects one file on line, without path and without extension.
> Files must be placed in class directory.
> If first line of playlist contains exactly one character '%', files will be
> ordered randomly.
> 
> 
> Diffs
> -----
> 
>   /trunk/res/res_musiconhold.c 412895 
>   /trunk/configs/musiconhold.conf.sample 412895 
>   /trunk/CHANGES 412895 
> 
> Diff: https://reviewboard.asterisk.org/r/3471/diff/
> 
> 
> Testing
> -------
> 
> Original 'static' behavior with dynamic=no
> Dynamic class without playlist
> Dynamic class with playlist
> Random ordering with % on first line of playlist 
> % as audio file name
> 
> 
> Thanks,
> 
> Vitezslav Novy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140422/4625c48f/attachment.html>