[asterisk-dev] [Code Review] 3471: Filesystem based dynamic MoH classes

[Olle E. Johansson]

On 22 Apr 2014, at 16:41, Vitezslav Novy <vnovy at vnovy.net> wrote:

> On 04/22/14 16:07, Olle E. Johansson wrote:
>> Please explain what the benefit of this over the existing methods
>> are.
> 
> 1/
> It allows create/delete/modify MoH classes on fly without module reload
> and without realtime feature.
Why not create a realtime text driver and you are there?

> 
> 2/
> It introduces concept of playlist.
What is the benefit of a playlist?

> 
> 
>> 
>> I would prefer using musiconhold.conf and have a mode that you list
>> files in by just adding them to a [section]. That way, you could just
>> include the playlists in musiconhold.conf without changing or
>> ignoring. The different classes could be combined instead of
>> ignored.
> 
> If you speak about audio files in [section] of musiconhold.conf I think it is step in opposite direction than this patch tries to go, i.e. more flexibility without module reload.
How do you change the playlists then? Curious. What can update/modify playlists but not issue a reload of a class.

> But I agree with you that combining dynamic classes and classes defined in config file is better idea then ignoring classes in config file when dynamic classes are on.

Ignoring will cause a lot of support. That is a bad idea.

/O