[asterisk-dev] [Code Review] 2478: Support multiple Require: and Supported: headers in the same request

Matt Jordan reviewboard at asterisk.org
Sun Apr 13 18:54:39 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2478/#review11595
-----------------------------------------------------------

Ship it!


Other than the red blobs, looks good :-)

- Matt Jordan


On April 11, 2014, 9:36 a.m., Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2478/
> -----------------------------------------------------------
> 
> (Updated April 11, 2014, 9:36 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21721
>     https://issues.asterisk.org/jira/browse/ASTERISK-21721
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> We have servers sending multiple Supported: and Require: options in separate headers in the same message. This patch fixes that support so that we parse more than the first header found.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/sip/reqresp_parser.c 412208 
>   /trunk/channels/chan_sip.c 412208 
> 
> Diff: https://reviewboard.asterisk.org/r/2478/diff/
> 
> 
> Testing
> -------
> 
> Tested with the server that caused the issue. Problem solved and we did reach interoperability!
> 
> 
> Thanks,
> 
> Olle E Johansson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140413/81d10f63/attachment.html>


More information about the asterisk-dev mailing list