[asterisk-dev] [Code Review] 2872: Pre-review of work to handle SRTP lifetime and MKI in a less bad way, but not the best way

[Olle E Johansson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2872/
-----------------------------------------------------------

Review request for Asterisk Developers and mattjordan.


Bugs: ASTERISK-17899
    https://issues.asterisk.org/jira/browse/ASTERISK-17899


Repository: Asterisk


Description
-------

Asterisk 1.8 and later currently just refuse calls that have an SDP lifetime parameter, even if it's ridiculously high. This patch adds a treshold of 10 hours (that could be made configurable) and refuse calls with a shorter lifetime. It also parses MKI/Lifetime properly.

This is not ready for commit anywhere, but I wanted to know if we can agree that this is a good path moving forward. 


Diffs
-----


Diff: https://reviewboard.asterisk.org/r/2872/diff/


Testing
-------

I've sent all kind of weird SDES keys from the README.lingon and while it failed previously it now succeeds where I want to and fail when I want it to fail.


Thanks,

Olle E Johansson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140411/76bb88bb/attachment.html>