[asterisk-dev] [Code Review] 1421: AMI :: Debug manager actions in the CLI

Matt Jordan reviewboard at asterisk.org
Sun Apr 13 18:52:27 CDT 2014



> On April 11, 2014, 10:02 a.m., Olle E Johansson wrote:
> > I've used this for a very long time in my own version of Asterisk and still find it useful. Shouldn't we try to make something along these lines happen?

The purpose of the patch is to debug AMI actions on an active system. While this could be implemented as a logger.conf channel, it would be relatively different from the existing logger channels. Logger channels today specify destinations for log messages. Some of these have special purposes (console, syslog); otherwise they specify files to create. Having a log channel of 'manager' that specifies which messages to send - and not their destination - would be a relatively new/different thing to create. (OTOH, having a 'manager' destination that accepted log messages would be ... interesting? Maybe? But not germane to this patch)

As such, I tend to agree with Olle here: this is just a debug switch. We have plenty of those in .conf file for helping system administrators debug problems.

A CLI command that toggled this behaviour would be ideal, but is not strictly necessary.


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1421/#review11580
-----------------------------------------------------------


On Sept. 19, 2011, 1:45 a.m., Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1421/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2011, 1:45 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-18447
>     https://issues.asterisk.org/jira/browse/ASTERISK-18447
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Adds a new option to manager.conf. When enabled, all manager actions will be output in the CLI session, in order to be able to debug a system controlled by AMI connections.
> 
> Red dots will be removed before commit
> 
> 
> Diffs
> -----
> 
>   /team/oej/rana-manager-debug-trunk/main/manager.c 334684 
>   /team/oej/rana-manager-debug-trunk/configs/manager.conf.sample 334684 
> 
> Diff: https://reviewboard.asterisk.org/r/1421/diff/
> 
> 
> Testing
> -------
> 
> Works fine on my system and a system at customer site in 1.4 version. The 1.8 version is not much different.
> 
> 
> Thanks,
> 
> Olle E Johansson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140413/f957bba0/attachment.html>


More information about the asterisk-dev mailing list