<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1421/">https://reviewboard.asterisk.org/r/1421/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 11th, 2014, 10:02 a.m. CDT, <b>Olle E Johansson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've used this for a very long time in my own version of Asterisk and still find it useful. Shouldn't we try to make something along these lines happen?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The purpose of the patch is to debug AMI actions on an active system. While this could be implemented as a logger.conf channel, it would be relatively different from the existing logger channels. Logger channels today specify destinations for log messages. Some of these have special purposes (console, syslog); otherwise they specify files to create. Having a log channel of 'manager' that specifies which messages to send - and not their destination - would be a relatively new/different thing to create. (OTOH, having a 'manager' destination that accepted log messages would be ... interesting? Maybe? But not germane to this patch)
As such, I tend to agree with Olle here: this is just a debug switch. We have plenty of those in .conf file for helping system administrators debug problems.
A CLI command that toggled this behaviour would be ideal, but is not strictly necessary.</pre>
<br />
<p>- Matt</p>
<br />
<p>On September 19th, 2011, 1:45 a.m. CDT, Olle E Johansson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Olle E Johansson.</div>
<p style="color: grey;"><i>Updated Sept. 19, 2011, 1:45 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-18447">ASTERISK-18447</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adds a new option to manager.conf. When enabled, all manager actions will be output in the CLI session, in order to be able to debug a system controlled by AMI connections.
Red dots will be removed before commit</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works fine on my system and a system at customer site in 1.4 version. The 1.8 version is not much different.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/team/oej/rana-manager-debug-trunk/main/manager.c <span style="color: grey">(334684)</span></li>
<li>/team/oej/rana-manager-debug-trunk/configs/manager.conf.sample <span style="color: grey">(334684)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1421/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>