[asterisk-dev] [Code Review] 3418: Test the DeviceStateChange and PresenceStateChange AMI events

[Kevin Harwell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3418/#review11503
-----------------------------------------------------------

Ship it!


- Kevin Harwell


On April 4, 2014, 2:38 p.m., Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3418/
> -----------------------------------------------------------
> 
> (Updated April 4, 2014, 2:38 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> These are simple tests that ensure the new events introduced in /r/3417 are being emitted properly.
> 
> If you're curious why I didn't use an orderedheadermatch AMI event instance in my test-config.yaml files here, it's because if I do that, then there's no way to detect that the test has completed before the reactor timeout. These tests run in ~4 seconds instead of about ~30 as a result.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/manager/tests.yaml 4836 
>   /asterisk/trunk/tests/manager/presence_state_changed/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/manager/presence_state_changed/ami_presence_state.py PRE-CREATION 
>   /asterisk/trunk/tests/manager/device_state_changed/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/manager/device_state_changed/ami_device_state.py PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3418/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mark Michelson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140404/6c41fd93/attachment.html>