[asterisk-dev] [Code Review] 3418: Test the DeviceStateChange and PresenceStateChange AMI events

Mark Michelson reviewboard at asterisk.org
Fri Apr 4 14:38:31 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3418/
-----------------------------------------------------------

Review request for Asterisk Developers.


Repository: testsuite


Description
-------

These are simple tests that ensure the new events introduced in /r/3417 are being emitted properly.

If you're curious why I didn't use an orderedheadermatch AMI event instance in my test-config.yaml files here, it's because if I do that, then there's no way to detect that the test has completed before the reactor timeout. These tests run in ~4 seconds instead of about ~30 as a result.


Diffs
-----

  /asterisk/trunk/tests/manager/tests.yaml 4836 
  /asterisk/trunk/tests/manager/presence_state_changed/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/manager/presence_state_changed/ami_presence_state.py PRE-CREATION 
  /asterisk/trunk/tests/manager/device_state_changed/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/manager/device_state_changed/ami_device_state.py PRE-CREATION 

Diff: https://reviewboard.asterisk.org/r/3418/diff/


Testing
-------


Thanks,

Mark Michelson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140404/3a870297/attachment-0001.html>


More information about the asterisk-dev mailing list