[asterisk-dev] [Code Review] 2851: chan_sip: Remove requirement for resolving host when outbound proxy in use

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2851/
-----------------------------------------------------------

(Updated Sept. 14, 2013, 7:30 p.m.)


Review request for Asterisk Developers.


Changes
-------

Fixes case where a global outbound proxy is specified and a Dial occurs without a peer.


Bugs: ASTERISK-21231 and ASTERISK-21694
    https://issues.asterisk.org/jira/browse/ASTERISK-21231
    https://issues.asterisk.org/jira/browse/ASTERISK-21694


Repository: Asterisk


Description
-------

During the development of 1.8 chan_sip was moved to using dnsmgr for host resolution. These changes introduced a regression where all hosts were looked up in DNS, including when an outbound proxy is in use. This is incorrect. The attached change removes this requirement.


Diffs (updated)
-----

  /branches/1.8/channels/chan_sip.c 398742 

Diff: https://reviewboard.asterisk.org/r/2851/diff/


Testing
-------

Configured an outbound proxy at global and peer level, confirmed that no resolution occurs for the host and also that traffic goes to where it should. Removed outbound proxy and confirmed things returned to normal.


Thanks,

Joshua Colp

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130914/afbe603b/attachment.htm>