[asterisk-dev] [Code Review] 2851: chan_sip: Remove requirement for resolving host when outbound proxy in use

Paul Belanger reviewboard at asterisk.org
Sat Sep 14 14:03:00 CDT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2851/#review9707
-----------------------------------------------------------


So, had a chance to play with this patch.  I backported it to a version of 1.8.7.1 for testing, here was my results:

Pre-patch: http://pastebin.com/RJ16Qu6e
Post-patch: http://pastebin.com/JP53misS

You can see, inbound authentication seems to fail and sip show peers looks empty.  From what I see asterisk was no longer able to reslove my local peers. Here is my realivent sip.conf:

[general](+)
nat = no
udpbindaddr = 209.87.247.153:15060
outboundproxy = kamailio-01-prod.polybeacon.com
srvlookup = no

[kamailio-01-prod]
type = peer
host = kamailio-01-prod.polybeacon.com
port = 5060
context = from-kamailio
insecure=port,invite

[kamailio]
type = peer
host = kamailio-01-prod.polybeacon.com
port = 5060

Going to take some for me to setup a testing environment with the lastest 1.8, hopefully these results will help.

- Paul Belanger


On Sept. 13, 2013, 1:53 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2851/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2013, 1:53 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21231 and ASTERISK-21694
>     https://issues.asterisk.org/jira/browse/ASTERISK-21231
>     https://issues.asterisk.org/jira/browse/ASTERISK-21694
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> During the development of 1.8 chan_sip was moved to using dnsmgr for host resolution. These changes introduced a regression where all hosts were looked up in DNS, including when an outbound proxy is in use. This is incorrect. The attached change removes this requirement.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/channels/chan_sip.c 398742 
> 
> Diff: https://reviewboard.asterisk.org/r/2851/diff/
> 
> 
> Testing
> -------
> 
> Configured an outbound proxy at global and peer level, confirmed that no resolution occurs for the host and also that traffic goes to where it should. Removed outbound proxy and confirmed things returned to normal.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130914/b0bbe566/attachment.htm>


More information about the asterisk-dev mailing list