[asterisk-dev] [Code Review] 2822: testsuite: blindxfer_setup, atxfer_setup, and transfer_capabilities tests updated for Asterisk 12

Mark Michelson reviewboard at asterisk.org
Thu Sep 5 10:31:39 CDT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2822/#review9597
-----------------------------------------------------------

Ship it!


Ship It!

- Mark Michelson


On Sept. 4, 2013, 4:17 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2822/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2013, 4:17 p.m.)
> 
> 
> Review request for Asterisk Developers, kmoore and Matt Jordan.
> 
> 
> Bugs: ASTERISK-22324
>     https://issues.asterisk.org/jira/browse/ASTERISK-22324
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> Uses python library changes from https://reviewboard.asterisk.org/r/2799/ to add AMI functionality for IDs/before and after ID event matching
> 
> As with other bridge tests I've been working on, CEL events have changed and aren't always predictable in order as of 12. This addresses that problem in the tests by using partially ordered matching. In addition, I've split up the transfer_capabilities tests into the 11-compatible tests which just set features via Dial application options and the BRIDGEFEATURES variant which only works properly with 12 (similar to the automon/automixmon tests).
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/bridge/atxfer_setup/test-config.yaml 4102 
>   /asterisk/trunk/tests/bridge/blindxfer_setup/test-config.yaml 4102 
>   /asterisk/trunk/tests/bridge/tests.yaml 4102 
>   /asterisk/trunk/tests/bridge/transfer_capabilities/configs/ast1/extensions.conf 4102 
>   /asterisk/trunk/tests/bridge/transfer_capabilities/test-config.yaml 4102 
>   /asterisk/trunk/tests/bridge/transfer_capabilities_bridgefeatures/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/bridge/transfer_capabilities_bridgefeatures/test-config.yaml PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/2822/diff/
> 
> 
> Testing
> -------
> 
> Ran all tests against 11 and 12 to make sure that the outcomes would be the expected outcomes (passing except in the case of 11 running the bridgefeatures variant of transfer_capabilities, which is skipped).
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130905/21931468/attachment-0001.htm>


More information about the asterisk-dev mailing list