<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2822/">https://reviewboard.asterisk.org/r/2822/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- Mark</p>
<br />
<p>On September 4th, 2013, 4:17 p.m. UTC, jrose wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers, kmoore and Matt Jordan.</div>
<div>By jrose.</div>
<p style="color: grey;"><i>Updated Sept. 4, 2013, 4:17 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-22324">ASTERISK-22324</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Uses python library changes from https://reviewboard.asterisk.org/r/2799/ to add AMI functionality for IDs/before and after ID event matching
As with other bridge tests I've been working on, CEL events have changed and aren't always predictable in order as of 12. This addresses that problem in the tests by using partially ordered matching. In addition, I've split up the transfer_capabilities tests into the 11-compatible tests which just set features via Dial application options and the BRIDGEFEATURES variant which only works properly with 12 (similar to the automon/automixmon tests).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ran all tests against 11 and 12 to make sure that the outcomes would be the expected outcomes (passing except in the case of 11 running the bridgefeatures variant of transfer_capabilities, which is skipped).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/tests/bridge/atxfer_setup/test-config.yaml <span style="color: grey">(4102)</span></li>
<li>/asterisk/trunk/tests/bridge/blindxfer_setup/test-config.yaml <span style="color: grey">(4102)</span></li>
<li>/asterisk/trunk/tests/bridge/tests.yaml <span style="color: grey">(4102)</span></li>
<li>/asterisk/trunk/tests/bridge/transfer_capabilities/configs/ast1/extensions.conf <span style="color: grey">(4102)</span></li>
<li>/asterisk/trunk/tests/bridge/transfer_capabilities/test-config.yaml <span style="color: grey">(4102)</span></li>
<li>/asterisk/trunk/tests/bridge/transfer_capabilities_bridgefeatures/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/bridge/transfer_capabilities_bridgefeatures/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2822/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>