[asterisk-dev] [Code Review] 2916: ARI: Add early media playback, DTMF, and indications

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2916/
-----------------------------------------------------------

(Updated Oct. 28, 2013, 7:23 p.m.)


Review request for Asterisk Developers.


Changes
-------

Updated based on last round of conversation on asterisk-app-dev re: early media.


Bugs: ASTERISK-22701
    https://issues.asterisk.org/jira/browse/ASTERISK-22701


Repository: Asterisk


Description
-------

The attached patch adds some additional useful functionality:

1. It is now possible to disable explicit answering when doing a playback, which can be used for early media.

2. DTMF can now be posted to a channel which sends the DTMF to it.

3. Indications can now be posted to a channel.


Diffs (updated)
-----

  /branches/12/include/asterisk/stasis_app.h 402126 
  /branches/12/res/ari/resource_channels.h 402126 
  /branches/12/res/ari/resource_channels.c 402126 
  /branches/12/res/res_ari_channels.c 402126 
  /branches/12/res/res_stasis_playback.c 402126 
  /branches/12/res/stasis/control.c 402126 
  /branches/12/rest-api/api-docs/channels.json 402126 

Diff: https://reviewboard.asterisk.org/r/2916/diff/


Testing
-------

Tested invoking everything as expected, plus off nominals (missing values, incorrect values).


Thanks,

Joshua Colp

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131028/4de69edc/attachment.html>