[asterisk-dev] [Code Review] 2916: ARI: Add early media playback, DTMF, and indications

[Joshua Colp]

> On Oct. 25, 2013, 1:52 p.m., Paul Belanger wrote:
> > /branches/12/rest-api/api-docs/channels.json, lines 738-746
> > <https://reviewboard.asterisk.org/r/2916/diff/2/?file=47375#file47375line738>
> >
> >     I still think this is going down a rabbit hole.  I'd say, remove it for now and have users explicitly use /answer or not for early media.

Matt asked about this on the mailing list, we should keep it going there.


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2916/#review9993
-----------------------------------------------------------


On Oct. 23, 2013, 2:40 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2916/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2013, 2:40 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22701
>     https://issues.asterisk.org/jira/browse/ASTERISK-22701
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The attached patch adds some additional useful functionality:
> 
> 1. It is now possible to disable explicit answering when doing a playback, which can be used for early media.
> 
> 2. DTMF can now be posted to a channel which sends the DTMF to it.
> 
> 3. Indications can now be posted to a channel.
> 
> 
> Diffs
> -----
> 
>   /branches/12/include/asterisk/stasis_app.h 401487 
>   /branches/12/include/asterisk/stasis_app_playback.h 401487 
>   /branches/12/res/ari/resource_bridges.c 401487 
>   /branches/12/res/ari/resource_channels.h 401487 
>   /branches/12/res/ari/resource_channels.c 401487 
>   /branches/12/res/res_ari_channels.c 401487 
>   /branches/12/res/res_stasis_playback.c 401487 
>   /branches/12/res/stasis/control.c 401487 
>   /branches/12/rest-api/api-docs/channels.json 401487 
> 
> Diff: https://reviewboard.asterisk.org/r/2916/diff/
> 
> 
> Testing
> -------
> 
> Tested invoking everything as expected, plus off nominals (missing values, incorrect values).
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131025/49513e98/attachment.html>