[asterisk-dev] [Code Review] 2913: Test Suite: add support for the 'atxferthreeway' feature and a test for it

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2913/#review9946
-----------------------------------------------------------

Ship it!


Ship It!

- Mark Michelson


On Oct. 15, 2013, 7:43 p.m., jbigelow wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2913/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2013, 7:43 p.m.)
> 
> 
> Review request for Asterisk Developers, kmoore and Mark Michelson.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This does the following:
> * adds support for the 'atxferthreeway' feature to the BridgeTestCase class (with a few additional debug messages).
> * adds a test to verify that the 'atxferthreeway' feature is detected and executed.
> 
> The test sets up a bridge between two endpoints and initiates an attended transfer without completing it. Then executes the attended transfer three-way call feature and ensures it is detected and executed properly. Two transfers are performed; one initiated by Alice, and the other by Bob. In both cases, the destination is Charlie.
> 
> This depends on a test event being added to Asterisk 12/trunk. See review 2912 (https://reviewboard.asterisk.org/r/2912/).
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/configs/bridge/ast1/features.conf 4263 
>   /asterisk/trunk/lib/python/asterisk/BridgeTestCase.py 4263 
>   /asterisk/trunk/sample-yaml/bridge-config.yaml.sample 4263 
>   /asterisk/trunk/tests/bridge/atxfer_threeway_nominal/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/bridge/atxfer_threeway_nominal/configs/ast1/sip-alice.conf PRE-CREATION 
>   /asterisk/trunk/tests/bridge/atxfer_threeway_nominal/configs/ast4/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/bridge/atxfer_threeway_nominal/configs/ast4/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/bridge/atxfer_threeway_nominal/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/bridge/tests.yaml 4263 
> 
> Diff: https://reviewboard.asterisk.org/r/2913/diff/
> 
> 
> Testing
> -------
> 
> * Ensured the test failed if the expected AMI events weren't matched
> * Ensured the test failed when the 'atxferthreeway' feature was removed from features.conf
> * Ensured the test failed if not all channels were hung up
> * Executed the test in a loop which passed until one of the Asterisk instances crash; See https://issues.asterisk.org/jira/browse/ASTERISK-22709
> 
> 
> Thanks,
> 
> jbigelow
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131017/d937dd75/attachment.html>