<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2913/">https://reviewboard.asterisk.org/r/2913/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- Mark</p>
<br />
<p>On October 15th, 2013, 7:43 p.m. UTC, jbigelow wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers, kmoore and Mark Michelson.</div>
<div>By jbigelow.</div>
<p style="color: grey;"><i>Updated Oct. 15, 2013, 7:43 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This does the following:
* adds support for the 'atxferthreeway' feature to the BridgeTestCase class (with a few additional debug messages).
* adds a test to verify that the 'atxferthreeway' feature is detected and executed.
The test sets up a bridge between two endpoints and initiates an attended transfer without completing it. Then executes the attended transfer three-way call feature and ensures it is detected and executed properly. Two transfers are performed; one initiated by Alice, and the other by Bob. In both cases, the destination is Charlie.
This depends on a test event being added to Asterisk 12/trunk. See review 2912 (https://reviewboard.asterisk.org/r/2912/).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* Ensured the test failed if the expected AMI events weren't matched
* Ensured the test failed when the 'atxferthreeway' feature was removed from features.conf
* Ensured the test failed if not all channels were hung up
* Executed the test in a loop which passed until one of the Asterisk instances crash; See https://issues.asterisk.org/jira/browse/ASTERISK-22709</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/configs/bridge/ast1/features.conf <span style="color: grey">(4263)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/BridgeTestCase.py <span style="color: grey">(4263)</span></li>
<li>/asterisk/trunk/sample-yaml/bridge-config.yaml.sample <span style="color: grey">(4263)</span></li>
<li>/asterisk/trunk/tests/bridge/atxfer_threeway_nominal/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/bridge/atxfer_threeway_nominal/configs/ast1/sip-alice.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/bridge/atxfer_threeway_nominal/configs/ast4/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/bridge/atxfer_threeway_nominal/configs/ast4/sip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/bridge/atxfer_threeway_nominal/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/bridge/tests.yaml <span style="color: grey">(4263)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2913/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>