[asterisk-dev] [Code Review] 2910: ARI: Return snapshot of channel when originating and allow optional app subscription

[David Lee]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2910/#review9929
-----------------------------------------------------------



/branches/12/main/pbx.c
<https://reviewboard.asterisk.org/r/2910/#comment19167>

    The fact that this is the only change you had to make to pbx.c makes me laugh.



/branches/12/rest-api/api-docs/channels.json
<https://reviewboard.asterisk.org/r/2910/#comment19166>

    From an API perspective, though, it's really odd to have two places to specify the application. And I can't think of a good reason why someone would want the subscribed application to be different from the Stasis application.
    
    What if we simply specified "app" once? That app is subscribed to the channel early, in addition to being the Stasis() app the channel is put into when answered.


- David Lee


On Oct. 15, 2013, 9:52 a.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2910/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2013, 9:52 a.m.)
> 
> 
> Review request for Asterisk Developers and David Lee.
> 
> 
> Bugs: ASTERISK-22485
>     https://issues.asterisk.org/jira/browse/ASTERISK-22485
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Currently when originating a call using ARI no feedback is provided. This makes it extremely difficult to know what channel you just originated.
> 
> The attached patch tweaks functionality in two ways to help with this:
> 
> 1. A snapshot of the newly originated channel is returned.
> 2. The originator may optionally subscribe a Stasis application to an originated channel.
> 
> Using these an originator can know what channel it originated, and also follow it if it so chooses.
> 
> 
> Diffs
> -----
> 
>   /branches/12/rest-api/api-docs/channels.json 400957 
>   /branches/12/res/res_ari_channels.c 400957 
>   /branches/12/res/ari/resource_channels.c 400957 
>   /branches/12/res/ari/resource_channels.h 400957 
>   /branches/12/main/pbx.c 400957 
> 
> Diff: https://reviewboard.asterisk.org/r/2910/diff/
> 
> 
> Testing
> -------
> 
> Did some originations and confirmed that the snapshot is returned, and that the Stasis application is subscribed.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131016/ccf97f8e/attachment.html>