[asterisk-dev] [Code Review] 2910: ARI: Return snapshot of channel when originating and allow optional app subscription

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2910/#review9921
-----------------------------------------------------------

Ship it!



/branches/12/res/ari/resource_channels.c
<https://reviewboard.asterisk.org/r/2910/#comment19159>

    This is a place you can safely use sprintf since the size of uri has been created to be exactly the size needed for the string to be passed in. Not opening an issue for this since it's not essential to fix.


- Mark Michelson


On Oct. 15, 2013, 2:52 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2910/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2013, 2:52 p.m.)
> 
> 
> Review request for Asterisk Developers and David Lee.
> 
> 
> Bugs: ASTERISK-22485
>     https://issues.asterisk.org/jira/browse/ASTERISK-22485
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Currently when originating a call using ARI no feedback is provided. This makes it extremely difficult to know what channel you just originated.
> 
> The attached patch tweaks functionality in two ways to help with this:
> 
> 1. A snapshot of the newly originated channel is returned.
> 2. The originator may optionally subscribe a Stasis application to an originated channel.
> 
> Using these an originator can know what channel it originated, and also follow it if it so chooses.
> 
> 
> Diffs
> -----
> 
>   /branches/12/rest-api/api-docs/channels.json 400957 
>   /branches/12/res/res_ari_channels.c 400957 
>   /branches/12/res/ari/resource_channels.c 400957 
>   /branches/12/res/ari/resource_channels.h 400957 
>   /branches/12/main/pbx.c 400957 
> 
> Diff: https://reviewboard.asterisk.org/r/2910/diff/
> 
> 
> Testing
> -------
> 
> Did some originations and confirmed that the snapshot is returned, and that the Stasis application is subscribed.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131015/48c25f8b/attachment.html>